Swapping the quote style of a string for completions should swap _all_ quotes in the string#42650
Merged
weswigham merged 1 commit intomicrosoft:masterfrom Feb 4, 2021
Conversation
…_ quotes in the string
typescript-bot
added
Author: Team
For Uncommitted Bug
Member
|
I love CodeQL/Semmle.
|
Member
Author
|
In this case... that one seems bogus, since, y'know, we're looking to replace all instances of literal-backslash-quotemark with quotemark, not escape any backslashes or anything. |
jessetrinity
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a codeQL smell that looks to be a completions bug.